Commit graph

982 commits

Author SHA1 Message Date
tamaina
9bd3c82e6c fix: some fixes of multiple notification read ()
* fix: limit multiple notification read

* fix

* fix
2022-06-12 19:28:13 +09:00
Johann150
e161c0abe4 chore: synchronize visibility checks ()
* reuse single meId parameter

* unify code style

Use template string to avoid having to use escaped quote marks.

* fix: follower only notes are visible to mentioned users

This synchronizes the visibility rules with the Notes.isVisibleForMe
method from packages/backend/src/models/repositories/note.ts

* add comment
2022-06-11 16:14:44 +09:00
syuilo
01011ef9c5 update deps 2022-06-10 15:06:42 +09:00
syuilo
602df78fde Merge branch 'develop' of https://github.com/misskey-dev/misskey into develop 2022-06-10 14:56:07 +09:00
syuilo
7dc86abec3 chore: tweak logo 2022-06-10 14:56:05 +09:00
Johann150
c7a2c42cc2 enhance(federation): use ActivityPub defined property in favour of proprietary property. ()
* add activitypub `source` property

* parse MFM from new `source` attribute
2022-06-10 14:31:58 +09:00
Johann150
674029f700 enhance: improve documentation for /users/ endpoints ()
* docs: category & description for reset password

* docs: category & description for testing

* docs: descriptions for groups endpoints

* docs: descriptions for drive file endpoints

* docs: descriptions for sw endpoints

* docs: descriptions for user list endpoints

* docs: descriptions & result type for gallery posts

* docs: descriptions & result type for user endpoints

* docs: add return type for stats
2022-06-10 14:25:20 +09:00
Johann150
2461d16d12 refactor: use awaitAll to reduce duplication ()
* refactor: use awaitAll to reduce duplication

* fix lint

* fix typo
2022-06-08 17:59:48 +09:00
syuilo
6ba668f934 fix(test): make chart tests working 2022-06-05 20:37:24 +09:00
syuilo
e8fdd35808 Update .mocharc.json 2022-06-05 19:46:52 +09:00
tamaina
0d4b9f07f3 https://github.com/misskey-dev/misskey/pull/8764#discussion_r885749892 2022-06-04 23:34:23 +09:00
tamaina
87b6d5ea39 fix 2022-06-04 08:44:36 +00:00
tamaina
2665322b23 Merge branch 'develop' into pr/ThatOneCalculator/8764 2022-06-04 08:34:56 +00:00
syuilo
3f4101d17b use node 16 2022-06-04 17:26:56 +09:00
tamaina
ac4d6e1ac2 fix http-signature 2022-06-04 08:26:36 +00:00
syuilo
c9cd88a9db update summaly 2022-06-04 17:24:41 +09:00
tamaina
f595c068f9 yarn node => node
依存関係の記載不足の解消がかなり多いため、yarn nodeは使わない
2022-06-04 08:07:27 +00:00
tamaina
13d924b804 wip 2022-06-04 08:01:02 +00:00
syuilo
3661d1bc33 fix bug 2022-06-04 15:15:44 +09:00
syuilo
4bf3ed6c1e fix test 2022-06-04 14:25:30 +09:00
Johann150
102012aa9d fix: add id for activitypub follows ()
* add id for activitypub follows

* fix lint

* fix: follower must be local, followee must be remote

Misskey will only use ActivityPub follow requests for users that are local
and are requesting to follow a remote user. This check is to ensure that
this endpoint can not be used by other services or instances.

* fix: missing import

* render block with id

* fix comment
2022-06-04 13:52:42 +09:00
Johann150
86c04c4489 fix: ensure resolver does not fetch local resources via HTTP(S) ()
* refactor: parseUri types and checks

The type has been refined to better represent what it actually is. Uses of
parseUri are now also checking the parsed object type before resolving.

* cannot resolve URLs with fragments

* also take remaining part of URL into account

Needed for parsing the follows URIs.

* Resolver uses DbResolver for local

* remove unnecessary use of DbResolver

Using DbResolver would mean that the URL is parsed and handled again.
This duplicated processing can be avoided by querying the database directly.

* fix missing property name
2022-06-04 11:29:20 +09:00
Johann150
336eea9d93 fix: correctly render empty note text ()
Ensure that the _misskey_content attribute will always exist. Because
the API endpoint does not require the existence of the `text` field,
that field may be `undefined`. By using `?? null` it can be ensured
that the value is at least `null`.

Furthermore, the rendered HTML of a note with empty text will also be
the empty string. From git blame it seems that this behaviour was added
because of a Mastodon bug that might have previously existed. Hoever,
this seems to be no longer the case as I can find mastodon posts that
have empty content.

The code could be made a bit more succinct by using the null coercion
operator.
2022-06-03 23:18:44 +09:00
PikaDude
186cac05a2 User moderation details ()
* add more user details for admins to see

* fix some issues

* small style fix

as suggested by Johann150

Co-authored-by: Johann150 <johann@qwertqwefsday.eu>

* fix

Co-authored-by: Johann150 <johann@qwertqwefsday.eu>

Co-authored-by: Johann150 <johann@qwertqwefsday.eu>
2022-06-03 23:14:50 +09:00
syuilo
e0fb88f9fe Merge branch 'develop' of https://github.com/misskey-dev/misskey into develop 2022-06-03 23:08:18 +09:00
syuilo
dbab6abde4 fix(test): reset redis in e2e test
2022-06-03 23:08:15 +09:00
tamaina
064c81bcfe npm run => yarn 2022-06-03 22:39:07 +09:00
tamaina
8a92d4139d Merge branch 'develop' into pr/ThatOneCalculator/8764 2022-06-02 10:21:08 +00:00
ThatOneCalculator
3cff4e6144 pnpm = dont change paths 2022-05-31 19:44:04 -07:00
ThatOneCalculator
1aa7bce3ff package.json names 2022-05-31 19:41:15 -07:00
Johann150
7c9d07cd53 fix(mfm): remove duplicate br tag/newline () 2022-05-31 18:57:55 +09:00
Johann150
8e296b2398 fix: always remove completed tasks () 2022-05-31 17:54:02 +09:00
MeiMei
f59e364a85 Fix IP address rate limit ()
* Fix IP address rate limit

* CHANGELOG

* Tune getIpHash
2022-05-31 17:44:22 +09:00
ThatOneCalculator
bcb2355bbb 🙏 2022-05-31 00:13:41 -07:00
ThatOneCalculator
071c8958d1 Remove yarnrc for workspaces 2022-05-30 23:56:49 -07:00
ThatOneCalculator
480a8ffa6d :godmode: 2022-05-30 23:55:47 -07:00
ThatOneCalculator
ee9fb2d5d9 :goberserk: 2022-05-30 21:03:11 -07:00
ThatOneCalculator
6e16bed0a8 More yarn workspaces stuff 2022-05-30 17:31:24 -07:00
ThatOneCalculator
10a73439a9 tbh 2022-05-30 15:02:52 -07:00
ThatOneCalculator
caa9905c7d tbh 2022-05-30 15:02:31 -07:00
ThatOneCalculator
f325574ca1 fix the code that depends on node_modules 2022-05-29 22:19:40 -07:00
ThatOneCalculator
e50e8b98a1 Remove packages/*/yarn.lock 2022-05-29 18:19:30 -07:00
ThatOneCalculator
daa6ae548d Yarn berry 2022-05-29 12:40:08 -07:00
Johann150
3b970aae8a fix: add missing import
fix 
2022-05-29 14:33:42 +02:00
Johann150
ec47b46423 refactor: improve code quality ()
* remove unnecessary if

`Array.prototype.some` already returns a boolean so an if to return
true or false is completely unnecessary in this case.

* perf: use count instead of find

When using `count` instead of `findOneBy`, the data is not
unnecessarily loaded.

* remove duplicate null check

The variable is checked for null in the lines above and the function
returns if so. Therefore, it can not be null at this point.

* simplify `getJsonSchema`

Because the assigned value is `null` and the used keys are only
shallow, use of `nestedProperty.set` seems inappropriate. Because the
value is not read, the initial for loop can be replaced by a `for..in`
loop.

Since all keys will be assigned `null`, the condition of the ternary
expression in the nested function will always be true. Therefore the
recursion case will never happen. With this the nested function can be
eliminated.

* remove duplicate condition

The code above already checks `dragging` and returns if it is truthy.
Checking it again later is therefore unnecessary.

To make this more obvious the `return` is removed in favour of using
an if...else construct.

* remove impossible "unknown" time

The `ago` variable will always be a number and all non-negative numbers
are already covered by other cases, the negative case is handled with
`future` so there is no case when `unkown` could be achieved.
2022-05-29 15:15:52 +09:00
tamaina
1fe73d31ad fix(client): Vite related boot mechanism revision ()
* preload app css

* remove salt

* APP_FETCH_FAILED error

* set max-age to 15s
2022-05-29 10:58:54 +09:00
tamaina
86e6126dd7 preload app css () 2022-05-29 10:57:06 +09:00
Johann150
fef27a1e92 chore: remove unused imports 2022-05-28 21:17:23 +02:00
Johann150
4a8ea6f2d1 fix: validate text is not empty
fix 
2022-05-28 17:26:17 +02:00
Johann150
0738a65a78 enhance: replace signin CAPTCHA with rate limit ()
* enhance: rate limit works without signed in user

* fix: make limit key required for limiter

As before the fallback limiter key will be set from the endpoint name.

* enhance: use limiter for signin

* Revert "CAPTCHA求めるのは2fa認証が無効になっているときだけにした"

This reverts commit 02a43a310f6ad0cc9e9beccc26e51ab5b339e15f.

* Revert "feat: make captcha required when signin to improve security"

This reverts commit b21b0580058c14532ff3f4033e2a9147643bfca6.

* fix undefined reference

* fix: better error message

* enhance: only handle prefix of IPv6
2022-05-28 12:06:47 +09:00